Add an option to avoid auto-scrolling out of top dictionary #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After enabling this option, sometimes I do want to auto-scroll to the target dictionary. This could be addressed by adding a shortcut that scrolls to the current "scrollto" target. This way, when this option is on, auto-scrolling won't happen, but the user could trigger the scrolling manually (via the new shortcut) at any time. |
vedgy
force-pushed
the
add-avoid-auto-scrolling-out-of-top-dictionary-option
branch
from
1d97f74
to
036df2b
Compare
|
Added the Alt+T shortcut that scrolls to the current "scrollto" target as described above. Also inverted the option's meaning along with its default value for better clarity (the behavior is still not changed by default, until the user toggles the new option). |
|
when will this be merged ,I need features like this. |
|
handled in this xiaoyifang/goldendict-ng#9 |
|
@Abs62, three users expressed interest in this optional feature:
I think it would be useful for many more users who just haven't stumbled upon this pull request. Could you please review it? |
|
vedgy
force-pushed
the
add-avoid-auto-scrolling-out-of-top-dictionary-option
branch
from
f4f0ae8
to
036df2b
Compare
When a user clicks on a link in a dictionary or requests translation of a word by double-clicking or translates selection via the context menu, at first the article from the highest-priority dictionary is at the top. Then, after approximately one second, the article from the dictionary, out of which the translation was requested, becomes current and the view scrolls down to this article placing it on top, hiding articles from the dictionaries above it. Such application behavior is inconvenient in some workflows so that the user manually navigates to the top dictionary translation when this automatic scrolling happens. For example: a user has English->Russian dictionaries and English->English dictionaries. The English->Russian dictionaries are higher up in the dictionary order because they provide easier/faster to understand translations. Some rare words and phrases are missing from the English->Russian dictionaries however. Thus the user occasionally reads the English explanation of a word/phrase. When the user double-clicks on a word or follows a link in the English->English dictionary article, she would rather see translations from the preferable English->Russian dictionaries. The new option allows to disable automatic scrolling and ensure that articles from higher-priority dictionaries are visible. The option doesn't affect backward/forward navigation via arrow buttons or Alt+Arrow shortcuts: these still scroll to the stored vertical position among articles. This remaining automatic scrolling happens much faster, is not a problem for the described use case and hopefully for other use cases.
This new action is particularly useful when the "Automatically scroll to target article" option is disabled. Even if the user prefers translations from higher-priority dictionaries most of the time, sometimes she may want to read the target article. This action allows to quickly scroll to the target article via its Alt+T shortcut.
vedgy
force-pushed
the
add-avoid-auto-scrolling-out-of-top-dictionary-option
branch
from
b365bbe
to
6d53199
Compare
|
Rebased on master and added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user clicks a link in a dictionary or requests translation of
a word by double-clicking or translates selection via the context menu,
the definition in all dictionaries is displayed. Then the article from
the dictionary, out of which the translation was requested, becomes
current and the view scrolls down to this article placing it on top,
hiding translations from dictionaries above it.
This behavior is inconvenient in some workflows and forces the user to
manually navigate to the top dictionary translation each time this
auto-scrolling happens.
For example: a user has English->Russian dictionaries and
English->English dictionaries. The English->Russian dictionaries are
higher up in the dictionary order because they provide easier/faster to
understand translations. Some rare words and phrases are missing from
the English->Russian dictionaries however. So the user has to read the
English explanation of the word/phrase. When the user double-clicks a
word or follows a link in the English->English dictionary article, she
would rather see translations from the preferable English->Russian
dictionaries.
The new option allows to disable auto-scrolling and ensure that articles
from higher-priority dictionaries are visible. The option doesn't affect
backward/forward navigation via arrow buttons or Alt+Arrow shortcuts:
these still scroll to the stored vertical position among articles. This
remaining auto-scrolling is not a problem for the described use case and
hopefully for other potential use cases.