Update libzip to v1.9.2 && update DeveloperDocs #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omaha/base/libzip/* was updated to be compatible with 1.9.2, however these updates break the build when compile with 1.7.3 as referenced in the developer guide, and per the submodule config
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
nElzky
approved these changes
Apr 27, 2023
Amirko2
approved these changes
Jul 6, 2023
Amirko2
reviewed
Jul 6, 2023
third_party/libzip
Outdated
|
amfleming:main |
aboodic
approved these changes
Aug 1, 2023
malik167
approved these changes
Aug 8, 2023
| * libzip 1.7.3. Source code [here](https://libzip.org/download/libzip-1.7.3.tar.xz). Unzip the contents of `libzip-1.7.3.tar.gz\libzip-1.7.3.tar\libzip-1.7.3\` into the directory `third_party\libzip`. The Omaha repository contains two generated configuration files in `base\libzip`, or one could build the libzip library and generate the files. A change has been made to config.h to disable zip crypto `#undef HAVE_CRYPTO`, or else the zip code won't build because of a compile time bug. | ||
| * zlib 1.2.11. Source code [here](https://zlib.net/zlib-1.2.11.tar.gz). Unzip the contents of `zlib-1.2.11.tar.gz\zlib-1.2.11.tar\zlib-1.2.11\` into the directory `third_party\zlib`. | ||
| * Submodules for breakpad, googletest, libzip and zlib are pinned at correct versions. Simply run `git submodule init && git submodule update` from `omaha/` and git will pull in sources. | ||
| * [breakpad](https://github.com/google/breakpad/) |
There was a problem hiding this comment.
|
***@***.***
احصل على Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: malik167 ***@***.***>
Sent: Tuesday, August 8, 2023 3:03:38 AM
To: google/omaha ***@***.***>
Cc: Amirko2 ***@***.***>; Comment ***@***.***>
Subject: Re: [google/omaha] Update libzip to v1.9.2 && update DeveloperDocs (PR #514)
@malik167 approved this pull request.
**[1691414241969.png]<https://user-images.githubusercontent.com/140214196/258949745-915d8f5b-fd19-48d8-998f-3f5fb71dca99.png>
**
________________________________
In doc/DeveloperSetupGuide.md<#514 (comment)>:
@@ -41,13 +41,11 @@ The following packages are required to build Omaha:
* Google Protocol Buffers (currently tested with v3.17.3) [here](https://github.com/protocolbuffers/protobuf/releases).
* From the [release page](https://github.com/protocolbuffers/protobuf/releases), download the zip file `protoc-$VERSION-win32.zip`. It contains the protoc binary. Unzip the contents under `C:\protobuf`. After that, download the zip file `protobuf-cpp-$VERSION.zip`. Unzip the `src` sub-directory contents to `C:\protobuf\src`. If other directory is used, please edit the environment variables in the hammer.bat, specifically, `OMAHA_PROTOBUF_BIN_DIR` and `OMAHA_PROTOBUF_SRC_DIR`.
* Third-party dependencies:
- * breakpad. Download [here](https://github.com/google/breakpad/archive/refs/heads/main.zip). Tested with commit [bc7dda](google/breakpad@bc7ddae) from Aug 9, 2021.
- - Unzip everything inside `breakpad-master.zip\breakpad-master` to `third_party\breakpad`.
- * googletest. Download [here](https://github.com/google/googletest/archive/refs/heads/master.zip). Tested with commit [47f819c
-](google/googletest@47f819c) from Aug 10, 2021. This includes both gtest and gmock frameworks.
- - Unzip everything inside `googletest-master.zip\googletest-master` to `third_party\googletest`.
- * libzip 1.7.3. Source code [here](https://libzip.org/download/libzip-1.7.3.tar.xz). Unzip the contents of `libzip-1.7.3.tar.gz\libzip-1.7.3.tar\libzip-1.7.3\` into the directory `third_party\libzip`. The Omaha repository contains two generated configuration files in `base\libzip`, or one could build the libzip library and generate the files. A change has been made to config.h to disable zip crypto `#undef HAVE_CRYPTO`, or else the zip code won't build because of a compile time bug.
- * zlib 1.2.11. Source code [here](https://zlib.net/zlib-1.2.11.tar.gz). Unzip the contents of `zlib-1.2.11.tar.gz\zlib-1.2.11.tar\zlib-1.2.11\` into the directory `third_party\zlib`.
+ * Submodules for breakpad, googletest, libzip and zlib are pinned at correct versions. Simply run `git submodule init && git submodule update` from `omaha/` and git will pull in sources.
+ * [breakpad](https://github.com/google/breakpad/)
Hay
* ***@***.*** []```
@google-admin<https://github.com/google-admin> @GoogleCodeExporter<https://github.com/GoogleCodeExporter>
> > > > @googlebot
- [ ] -
—
Reply to this email directly, view it on GitHub<#514 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5YSFYQTWCRPLVPLFINOMKLXUF65VANCNFSM6AAAAAAUU2U5GY>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.