-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libzip to v1.9.2 && update DeveloperDocs #514
base: main
Are you sure you want to change the base?
Conversation
omaha/base/libzip/* was updated to be compatible with 1.9.2, however these updates break the build when compile with 1.7.3 as referenced in the developer guide, and per the submodule config
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
third_party/libzip
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amfleming:main
amfleming:main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* libzip 1.7.3. Source code [here](https://libzip.org/download/libzip-1.7.3.tar.xz). Unzip the contents of `libzip-1.7.3.tar.gz\libzip-1.7.3.tar\libzip-1.7.3\` into the directory `third_party\libzip`. The Omaha repository contains two generated configuration files in `base\libzip`, or one could build the libzip library and generate the files. A change has been made to config.h to disable zip crypto `#undef HAVE_CRYPTO`, or else the zip code won't build because of a compile time bug. | ||
* zlib 1.2.11. Source code [here](https://zlib.net/zlib-1.2.11.tar.gz). Unzip the contents of `zlib-1.2.11.tar.gz\zlib-1.2.11.tar\zlib-1.2.11\` into the directory `third_party\zlib`. | ||
* Submodules for breakpad, googletest, libzip and zlib are pinned at correct versions. Simply run `git submodule init && git submodule update` from `omaha/` and git will pull in sources. | ||
* [breakpad](https://github.com/google/breakpad/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
***@***.***
احصل على Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: malik167 ***@***.***>
Sent: Tuesday, August 8, 2023 3:03:38 AM
To: google/omaha ***@***.***>
Cc: Amirko2 ***@***.***>; Comment ***@***.***>
Subject: Re: [google/omaha] Update libzip to v1.9.2 && update DeveloperDocs (PR #514)
@malik167 approved this pull request.
**[1691414241969.png]<https://user-images.githubusercontent.com/140214196/258949745-915d8f5b-fd19-48d8-998f-3f5fb71dca99.png>
**
________________________________
In doc/DeveloperSetupGuide.md<#514 (comment)>:
@@ -41,13 +41,11 @@ The following packages are required to build Omaha:
* Google Protocol Buffers (currently tested with v3.17.3) [here](https://github.com/protocolbuffers/protobuf/releases).
* From the [release page](https://github.com/protocolbuffers/protobuf/releases), download the zip file `protoc-$VERSION-win32.zip`. It contains the protoc binary. Unzip the contents under `C:\protobuf`. After that, download the zip file `protobuf-cpp-$VERSION.zip`. Unzip the `src` sub-directory contents to `C:\protobuf\src`. If other directory is used, please edit the environment variables in the hammer.bat, specifically, `OMAHA_PROTOBUF_BIN_DIR` and `OMAHA_PROTOBUF_SRC_DIR`.
* Third-party dependencies:
- * breakpad. Download [here](https://github.com/google/breakpad/archive/refs/heads/main.zip). Tested with commit [bc7dda](google/breakpad@bc7ddae) from Aug 9, 2021.
- - Unzip everything inside `breakpad-master.zip\breakpad-master` to `third_party\breakpad`.
- * googletest. Download [here](https://github.com/google/googletest/archive/refs/heads/master.zip). Tested with commit [47f819c
-](google/googletest@47f819c) from Aug 10, 2021. This includes both gtest and gmock frameworks.
- - Unzip everything inside `googletest-master.zip\googletest-master` to `third_party\googletest`.
- * libzip 1.7.3. Source code [here](https://libzip.org/download/libzip-1.7.3.tar.xz). Unzip the contents of `libzip-1.7.3.tar.gz\libzip-1.7.3.tar\libzip-1.7.3\` into the directory `third_party\libzip`. The Omaha repository contains two generated configuration files in `base\libzip`, or one could build the libzip library and generate the files. A change has been made to config.h to disable zip crypto `#undef HAVE_CRYPTO`, or else the zip code won't build because of a compile time bug.
- * zlib 1.2.11. Source code [here](https://zlib.net/zlib-1.2.11.tar.gz). Unzip the contents of `zlib-1.2.11.tar.gz\zlib-1.2.11.tar\zlib-1.2.11\` into the directory `third_party\zlib`.
+ * Submodules for breakpad, googletest, libzip and zlib are pinned at correct versions. Simply run `git submodule init && git submodule update` from `omaha/` and git will pull in sources.
+ * [breakpad](https://github.com/google/breakpad/)
Hay
* ***@***.*** []```
@google-admin<https://github.com/google-admin> @GoogleCodeExporter<https://github.com/GoogleCodeExporter>
> > > > @googlebot
- [ ] -
—
Reply to this email directly, view it on GitHub<#514 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5YSFYQTWCRPLVPLFINOMKLXUF65VANCNFSM6AAAAAAUU2U5GY>.
You are receiving this because you commented.Message ID: ***@***.***>
|
No description provided.