Panel edit: Add e2e selectors to input fields #83246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
requested review from
oscarkilhed,
Sergej-Vlasov,
joshhunt and
L-M-K-B
and removed request for
a team
|
@grafana/grafana-frontend-platform can you take a look at this? :) |
Clarity-89
reviewed
Mar 12, 2024
| @@ -49,6 +50,7 @@ export function getPanelFrameCategory(props: OptionPaneRenderProps): OptionsPane | |||
| render: function renderTitle() { | |||
| return ( | |||
| <Input | |||
| data-testid={selectors.components.PanelEditor.OptionsPane.fieldInput('Title')} | |||
There was a problem hiding this comment.
Looking at these selectors I wonder why aren't we using Cypress testing library as it has the same idea as React Testing Library and would allow us to reuse the existing ways to query elements?
There was a problem hiding this comment.
Sorry I missed this comments.
There are many other factors affecting the choice of e2e testing framework for plugin e2e testing. You can find more information in this design doc. TLDR; Playwright was chosen because it's more extensible than Cypress.
Anyway, Cypress also has some kind of actionability checks so I think we would have faced the same issues there. .
Clarity-89
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds e2e selectors to the input fields for the common panel edit options.
[Add a brief description of what the feature or update does.]
Why do we need this feature?
Needed in e2e tests.
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Part of grafana/plugin-tools#724
Fixes #
Special notes for your reviewer:
Please check that: