Suggestion: The dialog resizing (for Windows OS), the template is not wrapped, style clean up

[janekptacijarabaci]

Ad #2191
The suggestion (for example).

[arantius]

I don't understand. These grippies are not in the kind of place that makes sense, I can't understand what they're each for.

[janekptacijarabaci]

Unfortunately, also I do not understand. What are those arrows? Arrows point to the <resizer> element - this allows you to stretch the window (in this case, horizontally).
I don't know how to do better...

[arantius]

Sorry I still don't understand this. The window can be resized just like any other, by its corner. Long text is truncated. Why this change?

[janekptacijarabaci]

The window can be resized just like any other, by its corner.

Confirmed on:
Ubuntu 15.04

Not confirmed on:
Windows 7/8.1 :-)
(windows are modal windows - the window resizing doesn't work)

And then I suggested: "The template is not wrapped". What is your opinion on this?

[arantius]

I don't know what "the template is not wrapped" means.

[janekptacijarabaci]

https://github.com/greasemonkey/greasemonkey/pull/2194/files#diff-bb4d6a2d4a58244882529c2436edfe21R53

I'm sorry for the big "commit". I can do better (resizing the window, new script template, fix typo/style clean up...). It was just the suggestion (for simplicity).

Now:

The suggestion:

[arantius]

Oh of course that's what you mean by "the template", your earlier screenshots were just overly cropped. Great.

Also, yes. Windows won't let you resize this window, but there's no reason to want that behavior.

[arantius]

49b1cc8 is only two lines and gets quite close to this, what do you think?

As far as I can tell the only thing it doesn't do is allow resizing when clicking the "options" button in the AOM.

[janekptacijarabaci]

It's not occurred to me :-)

As far as I can tell the only thing it doesn't do is allow resizing when clicking the "options" button in the AOM.

That's what this trick does:
https://bugzilla.mozilla.org/show_bug.cgi?id=267950#c9

install.rdf:

<em:optionsURL>javascript:opener.openDialog('chrome://greasemonkey/content/options.xul','','modal,resizable');window.close();</em:optionsURL>

Confirmed on:
Windows, Ubuntu
e10s off/on

[arantius]

Calling this done, filed #2300 to track the bit that isn't.

[jerone]

Maybe force not wrapping lines in the "New User Script" dialog "Includes" and "Excludes" settings. Makes the "One per line" comment clearer.