Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove batching_regex as arg to FilePathDataConnectors #9715

Draft
wants to merge 36 commits into
base: develop
Choose a base branch
from

Conversation

joshua-stauffer
Copy link
Member

@joshua-stauffer joshua-stauffer commented Apr 5, 2024

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 22d13bf
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66104dca49d26a0008b3584f
😎 Deploy Preview https://deploy-preview-9715.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.63%. Comparing base (b3d4769) to head (ab7661f).

❗ Current head ab7661f differs from pull request most recent head b0358bd. Consider uploading reports for the commit b0358bd to get more accurate results

Files Patch % Lines
...a_asset/data_connector/file_path_data_connector.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9715       +/-   ##
============================================
- Coverage    82.55%   64.63%   -17.92%     
============================================
  Files          511      509        -2     
  Lines        46482    46479        -3     
============================================
- Hits         38371    30042     -8329     
- Misses        8111    16437     +8326     
Flag Coverage Δ
3.10 64.63% <92.85%> (-0.01%) ⬇️
3.11 64.63% <92.85%> (-0.01%) ⬇️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 trino ?
3.8 64.64% <92.85%> (+<0.01%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.8 aws_deps ?
3.8 big ?
3.8 databricks ?
3.8 filesystem ?
3.8 mssql ?
3.8 mysql ?
3.8 postgresql ?
3.8 snowflake ?
3.8 spark ?
3.8 trino ?
3.9 64.63% <92.85%> (+0.01%) ⬆️
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshua-stauffer joshua-stauffer changed the title [FEATURE] Implement LegacyBatchDefinition.batching_regex [FEATURE] Remove batching_regex as arg to FilePathDataConnectors Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant