-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove major code smells from the source code #8742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 378ecb7:
|
budnix
changed the title
Fix all bugs found by SonarCloud
Remove major code smells from the source code
Sep 23, 2021
jansiegel
reviewed
Sep 27, 2021
jansiegel
approved these changes
Sep 27, 2021
budnix
added a commit
that referenced
this pull request
Sep 28, 2021
The commit removes all major code smells from the source code detected by the SonarCloud tool. Additionally, the commit fixes regular expression (marked as "risk") responsible for detecting numeric values. The expression causes performance degradation when an empty string is passed. Issue: #8752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR removes all major code smells from the source code detected by the SonarCloud tool. Additionally, the PR fixes regular expression (marked as "risk") responsible for detecting numeric values. The expression causes performance degradation when an empty string is passed.
Test code snippet:
Handsontable.helper.isNumeric(' '.repeat(100000));
Results:
isNumeric
helperWorking demo
I analyzed this branch after my changes and the results can be found here https://sonarcloud.io/summary/new_code?id=handsontable_handsontable&pullRequest=8742.
How has this been tested?
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
Checklist: