Template sweep -- fix bugs in Vue and Lit #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent trailing commas when field list ends in non-widget fields in EditFoo.svelte template
|
@pdaoust Same with this one, please can it target I'm happy reviewing the code but I don't know the repo well enough to understand what's changing without having a conversation about it if that's okay! :) |
ThetaSinner
force-pushed
the
2023-10-03-fix-vue-lit-templates
branch
from
56cb4dd
to
3ca29ed
Compare
ThetaSinner
added
ShouldBackport/0.1
|
This is now ready for review and can be merged when ready |
c12i
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Discovered similar bugs, at least for the Vue and Svelte templates hence why I am returning to this PR, I think we should be getting this PR merged as it does address some critical issues
@pdaoust kindly let me know if you are in a position to resolve the merge conflicts
…in/scaffolding into 2023-10-03-fix-vue-lit-templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't claim this is a thorough sweep that catches all bugs, but it does catch all bugs discovered via following the Getting Started Guide but choosing Lit and Vue instead of Svelte for the templating engine.