Prevent trailing commas when field list ends in non-widget fields in EditFoo.svelte template #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdaoust
changed the title
robbiecarlton
approved these changes
Sep 22, 2023
Comment on lines
+104
to
+111
| let widget_fields = fields | ||
| .iter() | ||
| .map(|f| f.clone()) | ||
| .filter(|f| match f.widget { | ||
| Some(_) => true, | ||
| None => false | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
Suggested change
| let widget_fields = fields | |
| .iter() | |
| .map(|f| f.clone()) | |
| .filter(|f| match f.widget { | |
| Some(_) => true, | |
| None => false | |
| }) | |
| .collect(); | |
| let widget_fields = fields.clone() | |
| .iter() | |
| .filter(|f| match f.widget { | |
| Some(_) => true, | |
| None => false | |
| }) | |
| .collect(); |
Less code, and I'm not 100% but I think it will also be marginally more efficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the most elegant way to do things -- it duplicates data; implementing a
filterhelper for Handlebars would've been much more elegant. But the advantage of this approach is that I can actually do it ;)I'm working on a possibly better solution that involves writing a
filterHandlebars helper, but I'd like to get things unblocked for the hackathon this weekend