fix: bug while scaffolding collection by author #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c12i
added
the
ShouldBackport/0.3
c12i
force-pushed
the
fix-scaffold-collection-by-author
branch
from
f863953
to
d9de059
Compare
ThetaSinner
approved these changes
May 20, 2024
c12i
added a commit
to c12i/scaffolding
that referenced
this pull request
May 20, 2024
* fix: bug while scaffolding collection by author * fix initial insert statement
c12i
removed
the
ShouldBackport/0.3
c12i
added a commit
that referenced
this pull request
May 20, 2024
* fix: invalid entry type fields in vue template (#279) * fix: prevent unaffected rust files from getting formatted (#281) * fix: preserve doc comments * fix: unmodified files getting reformatted by unparse * refactor map_all_files_rec function * revert unparse function change * fix: prevent scaffolding dead code (#280) * fix: prevent scaffolding dead code * fix clippy warnings * improve readability of stringified rust code * update coordinator functions * refactor boolean checks * feat: Add headless template (#267) * feat: add initial headless template * include headless template in ui framework choices * add web-app instructions and prefer explicit hc commands in all package.json templates * rename instructions template * fix indentation in instructions * update instructions * remove gitkeep * refactor UiFramework struct * refactor tempalte config access * remove assertion * revert renaming * revert integrity zome name * choose non vanilla framework for non hello world examples * simplify ui framework prompts; update instructions * update instructions * Update scripts and instructions * color code ui frameworks * templatify web-happ manifest * fix bug writing invalid template config * remove unnecessary print statement * remove unnecessary return statement * update ui framework try from filetree implementation * refactor: refactor reserved words check * update ansi colors for lit and svelte * Add build happ instruction * chore: update web-app instructions for headless template * fix: fix vue example ui server not starting (#284) * simplify templates_dir * chore: update manual testing docs (#285) * chore: update manual testing docs * update override * fix: bug while scaffolding collection by author (#290) * fix: bug while scaffolding collection by author * fix initial insert statement * chore: bump weekly
c12i
added a commit
that referenced
this pull request
May 22, 2024
* bump 0.3 * bump crate version * fix: bug while scaffolding collection by author (#290) * fix: bug while scaffolding collection by author * fix initial insert statement * fix: add missing headless field type samples (#292) * add missing headless field types * add missing package command from svelte scripts * bump lib versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isolated change was part of #288 where I am making a transition away from stringified rust code, which seems to cause bugs that can easily go unnoticed in code reviews