Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: poorly formatted rust code #288

Merged
merged 26 commits into from
May 22, 2024
Merged

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented May 17, 2024

this PR replaces all stringified rust code instances with quote macro usage in order to allow for unparse to consistently format all rust code that is generated by scaffolding, as well as improving readability of the code by enabling syntax highlighting of generated code making it easy to catch errors.

Closes #282
Closes #246

@c12i c12i added the ShouldBackport/0.3 This change should be backported to develop-0.3 label May 20, 2024
@c12i c12i requested a review from matthme May 21, 2024 10:24
@c12i c12i marked this pull request as ready for review May 21, 2024 10:24
@c12i c12i changed the title fix: poorly formatted code fix: poorly formatted rust code May 21, 2024
Copy link
Collaborator

@matthme matthme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not go through each replacement one by one but from what I can see it looks like a great imrovement!

src/utils.rs Show resolved Hide resolved
@c12i c12i merged commit e1e49c4 into holochain:develop May 22, 2024
7 checks passed
@c12i c12i removed the ShouldBackport/0.3 This change should be backported to develop-0.3 label Jun 5, 2024
c12i added a commit to c12i/scaffolding that referenced this pull request Jun 5, 2024
* fix: poorly formatted code in coordinator zome

* document add_newlines

* clearn up coordinators module

* clean up integrity module

* refactor utils

* fix add_newlines

* update integrity comments

* fix map file calls

* fix add_newlines

* make add_newlines public/private function agnostic

* refactor link-type coordinator

* fix  remove link handler

* fix collection coordinator

* clean up entry-type coordinator

* fix clippy warnings

* refactor link-type coordinator

* fix bug scaffolding entry-type with linked_from

* fix target_hash_variable

* remove unnecessary format usage

* remove unnecessary clone

* fix validate_delete_result

* move comment

* fix entry from rcord error message

* rename unparse function to unparse_pretty;
c12i added a commit that referenced this pull request Jun 6, 2024
* fix: poorly formatted rust code (#288)

* fix: poorly formatted code in coordinator zome

* document add_newlines

* clearn up coordinators module

* clean up integrity module

* refactor utils

* fix add_newlines

* update integrity comments

* fix map file calls

* fix add_newlines

* make add_newlines public/private function agnostic

* refactor link-type coordinator

* fix  remove link handler

* fix collection coordinator

* clean up entry-type coordinator

* fix clippy warnings

* refactor link-type coordinator

* fix bug scaffolding entry-type with linked_from

* fix target_hash_variable

* remove unnecessary format usage

* remove unnecessary clone

* fix validate_delete_result

* move comment

* fix entry from rcord error message

* rename unparse function to unparse_pretty;

* feat: add long disable fast track option to hc scaffold web-app (#293)

* add fix to prevent accumulation of dist.zip content (#300)

* chore: bump version

---------

Co-authored-by: matthme <36768177+matthme@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Bad formatting in entry-type.rs files enhancement: Ensure initially scaffolded code is well formatted
2 participants