Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonos restore calls #51565

Merged

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented Jun 7, 2021

Proposed change

Fix an async/sync mismatch in the group restore service introduced in #50277.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@jjlawren jjlawren added this to the 2021.6.3 milestone Jun 7, 2021
@project-bot project-bot bot added this to Needs review in Dev Jun 7, 2021
@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as its been labeled with an integration (sonos) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Reviewer approved Jun 7, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 85ce679 into home-assistant:dev Jun 7, 2021
Dev automation moved this from Reviewer approved to Done Jun 7, 2021
balloob pushed a commit that referenced this pull request Jun 7, 2021
@balloob balloob mentioned this pull request Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2021
@jjlawren jjlawren deleted the sonos_fix_bad_restore_async branch December 25, 2021 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Sonos TTS Automation Not Working
5 participants