Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Onvif get_time_zone from device #51620

Merged
merged 3 commits into from Jun 8, 2021
Merged

Fix Onvif get_time_zone from device #51620

merged 3 commits into from Jun 8, 2021

Conversation

pszafer
Copy link
Contributor

@pszafer pszafer commented Jun 8, 2021

Proposed change

zoneinfo.ZoneInfo(None) crashes with error:

  File "/usr/lib/python3.9/zoneinfo/_tzpath.py", line 67, in find_tzfile
    _validate_tzfile_path(key)
  File "/usr/lib/python3.9/zoneinfo/_tzpath.py", line 81, in _validate_tzfile_path
    if os.path.isabs(path):
  File "/usr/lib/python3.9/posixpath.py", line 62, in isabs 
    s = os.fspath(s)

This PR fixes if Onvif camera doesn't support timezone.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added bugfix core small-pr PRs with less than 30 lines. labels Jun 8, 2021
@project-bot project-bot bot added this to Needs review in Dev Jun 8, 2021
homeassistant/util/dt.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Jun 8, 2021
@pszafer pszafer changed the title Fix dt_util get_time_zone if None provided as argument Fix Onvif get_time_zone from device Jun 8, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@frenck frenck added this to the 2021.6.4 milestone Jun 8, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pszafer 馃憤

Dev automation moved this from Review in progress to Reviewer approved Jun 8, 2021
@frenck frenck merged commit abbd4d1 into home-assistant:dev Jun 8, 2021
Dev automation moved this from Reviewer approved to Done Jun 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

onvif stopped working in 2021.6.z
6 participants