New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release pin on pytest #2633
release pin on pytest #2633
Conversation
22c0c01
to
9bfddc8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2633 +/- ##
==========================================
- Coverage 54.37% 52.91% -1.47%
==========================================
Files 519 511 -8
Lines 60862 60265 -597
Branches 8398 8260 -138
==========================================
- Hits 33095 31889 -1206
- Misses 26094 26766 +672
+ Partials 1673 1610 -63
... and 87 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
9bfddc8
to
f896ede
Compare
055b2c4
to
63395bd
Compare
63395bd
to
8e400f9
Compare
8e400f9
to
ba9a190
Compare
use the same fixture for empty project file everywhere on osx tmp_path fixture resolves the symlink from /var to /private/var, while `tempfile.mkstemp` does not - relative path check would fail.
c7c4997
to
9de54ab
Compare
using `pytester` here - test failures on windows with multiple `run` invocations per test functions somehow modify the environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything runs, and some neat improvements in the tests 👍
thank you for the review @btbest ! |
Final blocking thing preventing us from updating Python was pytest. This updates pytest from
3.x
pin to 7.2.0 (latest, not pinned)There were some small real issues
tmp_path
magic that would resolve symlinks vstempfile.mk*
not doing it.pytester
, which is supposed to run tests in a more isolated manner (guess that was the motivation for using it, from the docs I take it is used to test pytest itself). Behavior ofpytester
testdir
fixture seems to have changed - since pytest 3.x. I didn't dig into the pytest source code, but somehow invokingrun
seems to alter the environment for subsequent calls torun
in the same test function. Splitting those functions means better reporting anyway. (In addition we could think about dropping the use ofpytester
here - I'm not sure it's supposed to be used outside the context of testing pytest itself).while debugging I simplified
appveyor.yml
a bit - but these changes are unrelated and I can also remove them.