New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node 16 #1880
base: main
Are you sure you want to change the base?
Upgrade to Node 16 #1880
Conversation
This needs to wait before we fix the CI/CD. One of the test return 401, something probably expired. If I merge this I will have a broken main branch, and I don't want that. But you can merge this to your other PR we will at least know if your code passes the tests that were failing because abortControler missing. |
yeah, I did, and the test is passing fine. |
@@ -15,7 +15,7 @@ jobs: | |||
steps: | |||
- task: NodeTool@0 | |||
inputs: | |||
versionSpec: '12.x' | |||
versionSpec: '16.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update this in the GitHub Workflow in #1879.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray.
As a non-blocking suggestion, we could set up ESLint to sort our imports consistently across all files. 🧹
I'm upgrading to Node 16 as discussed here.
abortMerge
, which were failing even before. Fixing them is another story.