Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 16 #1880

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ipeychev
Copy link

@ipeychev ipeychev commented Mar 8, 2024

I'm upgrading to Node 16 as discussed here.

  • Node 16 will be the minimal supported version
  • Typescript was upgraded to "5.4.2"
  • The same amount of tests are passing. There are some, like abortMerge, which were failing even before. Fixing them is another story.

@jcubic
Copy link
Contributor

jcubic commented Mar 8, 2024

This needs to wait before we fix the CI/CD. One of the test return 401, something probably expired. If I merge this I will have a broken main branch, and I don't want that. But you can merge this to your other PR we will at least know if your code passes the tests that were failing because abortControler missing.

@ipeychev
Copy link
Author

ipeychev commented Mar 8, 2024

yeah, I did, and the test is passing fine.
See the last commits here. And here are the results - test of push is passing successfully.
I also removed the code which was checking whether AbortController is available, or not, and now the test is just instantiating an AbortController.

@@ -15,7 +15,7 @@ jobs:
steps:
- task: NodeTool@0
inputs:
versionSpec: '12.x'
versionSpec: '16.x'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this in the GitHub Workflow in #1879.

Copy link
Contributor

@seanpoulter seanpoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray.

As a non-blocking suggestion, we could set up ESLint to sort our imports consistently across all files. 🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants