Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 16 #1880

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,15 @@
"contributions": [
"doc"
]
},
{
"login": "ipeychev",
"name": "Iliyan Peychev",
"avatar_url": "https://avatars.githubusercontent.com/u/78014?v=4",
"profile": "https://github.com/ipeychev",
"contributions": [
"code"
]
}
],
"commitConvention": "angular"
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds
<td align="center"><a href="https://api.github.com/users/hisco"><img src="https://avatars.githubusercontent.com/u/39222286?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Eyal Hisco</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/issues?q=author%3Ahisco" title="Bug reports">🐛</a></td>
<td align="center"><a href="https://github.com/scolladon"><img src="https://avatars.githubusercontent.com/u/522422?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Sebastien</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=scolladon" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/yarikoptic"><img src="https://avatars.githubusercontent.com/u/39889?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Yaroslav Halchenko</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=yarikoptic" title="Documentation">📖</a></td>
<td align="center"><a href="https://github.com/ipeychev"><img src="https://avatars.githubusercontent.com/u/78014?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Iliyan Peychev</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=ipeychev" title="Code">💻</a></td>
</tr>
</table>

Expand Down
14 changes: 9 additions & 5 deletions __tests__/__helpers__/find-unused-errors.cjs
Original file line number Diff line number Diff line change
@@ -1,21 +1,25 @@
const { E } = require('../..')
const replace = require('replace-in-file')
const { replaceInFile } = require('replace-in-file')

const E = require('../..')

const errors = Object.keys(E).map(name => `E.${name}`)
const bal = []

;(async () => {
for (const error of errors) {
let files = await replace({
const files = await replaceInFile({
files: ['src/**/*.js'],
from: error,
to: 'foo',
dry: true,
countMatches: true,
})
files = files.filter(file => file.numMatches > 0).map(file => file.file)
const filteredFiles = files
.filter(file => file.numMatches !== undefined && file.numMatches > 0)
.map(file => file.file)

// console.log(`${error}: ${files.length}`)
if (files.length > 0) {
if (filteredFiles.length > 0) {
bal.push(`${files.length} ${error}`)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const BrowsersReporter = function(
this.successfulBrowsersFullNames = tmp[0]
this.successfulBrowsers = tmp[1]
}
this.onBrowserComplete = function(browser) {
this.onBrowserComplete = browser => {
var results = browser.lastResult
if (results.disconnected || results.error || results.failed) {
this.buildOk = false
Expand Down
1 change: 1 addition & 0 deletions __tests__/test-addRemote.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ describe('addRemote', () => {
// Test
let error = null
try {
// @ts-ignore
await addRemote({ fs, dir, gitdir, remote, url })
} catch (err) {
error = err
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
- task: NodeTool@0
inputs:
versionSpec: '12.x'
versionSpec: '16.x'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this in the GitHub Workflow in #1879.

displayName: 'Install Node.js'

- task: 1ESLighthouseEng.PipelineArtifactCaching.RestoreAndSaveCacheV1.RestoreAndSaveCache@1
Expand Down