changed implementation of additionalBundlerResources
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is possible to create folders having the bundlerID, and when possible copying directly into these, without loosing the older behavior.
|
This is intended to fix #235 |
|
available as 8.7.1-SNAPSHOT |
|
DO NOT MERGE ! needs rewrite for the mac-parts ... |
The first idea was too naive, so this needed to be reimplemented completely. This now gets worked around and refactored a lot. Additionally the gradle-plugin got some more options, especially the options `failOnError`, `onlyCustomBundlers` and `skipJNLP` got added. The later one mostly makes sense in combination with `failOnError`, because the JNLP-bundler behaves different. Another important change is the switch default of the `checkForAbsolutePaths` option, which will get removed on the next release (I do know at least one person, who will be happy about this decision). This got migrated from FibreFoX/javafx-gradle-plugin@65cef6d
|
fixes #238 too |
|
Needs some IT-projects for having implementations regarding #238 being fully tested |
…x-maven-plugin into rewrite_additionalBundlerResources
|
This will be worked on soon ;) I'm in the preparation for a lot of mac-specific review until the end of this year. |
* moved detection-stuff to Workarounds-class * fixed our own "mac.app" detecting additional bundler files (now using "mac.app"-subfolder)
bumped version because there are some more additions upcoming
|
available as 8.8.0-SNAPSHOT |
FibreFoX
force-pushed
the
rewrite_additionalBundlerResources
branch
from
5361b94
to
dad5084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to create folders having the bundlerID, and when possible copying directly into these, without loosing the older behavior.
Setting:
<additionalBundlerResources>src/main/deploy/bundlers</additionalBundlerResources>and having:
src/main/deploy/bundlers/[bundlerid]/additionalFile1 ....