Test against Ruby 2.4.0 #5687
Test against Ruby 2.4.0 #5687
Conversation
- json: "~> 2.0"
# flori/json#303 (comment)
- pygments.rb: "~> 1.1"
ashmaroli
force-pushed
the
ruby-2.4.0
branch
from
344b339
to
e463813
Compare
.travis.yml
Outdated
| - &ruby1 2.4.0 | ||
| - &ruby2 2.3.1 | ||
| - &ruby3 2.2.5 | ||
| - &ruby4 2.1.9 |
There was a problem hiding this comment.
How about bumping previous versions? Current versions are 2.3.3, 2.2.6, and 2.1.10. https://www.ruby-lang.org/en/downloads/
There was a problem hiding this comment.
that's for a separate PR. This PR is only about Ruby 2.4.
You're welcome to create a PR to bump the rvm versions we currently test against.
😃
|
It looks like the pygments.rb update is causing issues. Does pygments.rb 1.0 work on Ruby 2.1, 2.2, and 2.3, too? If it does, then maybe we should just update! |
Gemfile
Outdated
| gem "json", "~> 2.0" | ||
| gem "pygments.rb", "~> 1.1" | ||
| else | ||
| gem "pygments.rb", "~> 0.6.0" unless RUBY_ENGINE == "jruby" |
There was a problem hiding this comment.
Can we use pygments.rb v1 with Ruby 2.1,2,3,4 instead of using 2 versions?
There was a problem hiding this comment.
we can.. but I wasn't sure if the change would affect Jekyll internally in any way..
I pushed a new commit to use just one version of pygments.rb
From the logs, it looks like we just need to change our assertions to match the new pygments syntax. But I don't want to undertake that task.
So, you're free to close this PR or assign someone to directly modify this branch.
|
Thank you! We should definitely upgrade the pygments.rb dependency as you already did, but it has caused a number of test failures. It would be preferable to see the upgrade & test failures fix in a separate PR so we can keep this focused on the 2.4 upgrade. It also occurs to me that we should check 2.4 on AppVeyor as well! If that's a possibility, it would be nice to keep Travis & AppVeyor in harmony. |
|
I think we can't test with /cc @XhmikosR |
|
Yeah, not possible. We need 2.4.0, but see oneclick/rubyinstaller#348 |
|
@ashmaroli @XhmikosR That settles it then! 👍 We'll wait on rubyinstaller for AppVeyor support and in the meantime we'll hope that the 2.4.0 tests on unix-like platforms will work for any brave souls who install Ruby 2.4.0 on their Windows machines. |
|
From the look of the test failures, it looks like the only thing that going to break is the pygments HTML output.. doesn't seem to be a serious issue, IMO |
Yeah, agreed. I would like to contain that change in one separate PR so we can always trace back. Feel free to simply fix the tests so the expectations match! The HTML that pygments outputs seems good enough to me. |
|
Thank you! |
Test against the latest version of Ruby: v2.4.0