Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [plg_privacy_message] Convert to prepared statement #25431

Merged
merged 3 commits into from
Jul 23, 2019

Conversation

HLeithner
Copy link
Member

@HLeithner HLeithner commented Jul 4, 2019

Summary of Changes

Updated SQL queries to prepared statements and made some cleanups around the queries. This PR needs joomla-framework/database#162

Testing Instructions

Use the plugin in all ways you can think of.

Create users
Generate privacy message entries.

Expected result

Nothing changed.

@HLeithner HLeithner requested a review from rdeutz as a code owner July 4, 2019 22:43
@ghost ghost changed the title [plg_privacy_message] Convert to prepared statement [4.0] [plg_privacy_message] Convert to prepared statement Jul 5, 2019
@brianteeman
Copy link
Contributor

Looks like there are two unrelated files here

@HLeithner
Copy link
Member Author

thx, I will fix all 3 PR later

@HLeithner
Copy link
Member Author

Removed the orWhere function based discussion joomla-framework/database#174

Co-Authored-By: SharkyKZ <sharkykz@gmail.com>
@SharkyKZ
Copy link
Contributor

I have tested this item ✅ successfully on 427423b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25431.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jul 17, 2019

I have tested this item ✅ successfully on 427423b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25431.

@Quy
Copy link
Contributor

Quy commented Jul 17, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25431.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 17, 2019
@wilsonge wilsonge merged commit 416627c into joomla:4.0-dev Jul 23, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 23, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jul 23, 2019
@HLeithner HLeithner deleted the prepared-plg-privacy-message branch March 29, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants