-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [plg_privacy_message] Convert to prepared statement #25431
Merged
wilsonge
merged 3 commits into
joomla:4.0-dev
from
HLeithner:prepared-plg-privacy-message
Jul 23, 2019
Merged
[4.0] [plg_privacy_message] Convert to prepared statement #25431
wilsonge
merged 3 commits into
joomla:4.0-dev
from
HLeithner:prepared-plg-privacy-message
Jul 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
[plg_privacy_message] Convert to prepared statement
[4.0] [plg_privacy_message] Convert to prepared statement
Jul 5, 2019
Looks like there are two unrelated files here |
thx, I will fix all 3 PR later |
Quy
reviewed
Jul 5, 2019
HLeithner
force-pushed
the
prepared-plg-privacy-message
branch
from
July 7, 2019 13:54
9e74991
to
5759533
Compare
Removed the orWhere function based discussion joomla-framework/database#174 |
SharkyKZ
reviewed
Jul 15, 2019
Co-Authored-By: SharkyKZ <sharkykz@gmail.com>
I have tested this item ✅ successfully on 427423b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25431. |
1 similar comment
I have tested this item ✅ successfully on 427423b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25431. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25431. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updated SQL queries to prepared statements and made some cleanups around the queries. This PR needs joomla-framework/database#162
Testing Instructions
Use the plugin in all ways you can think of.
Create users
Generate privacy message entries.
Expected result
Nothing changed.