Prevent AttributeError in stop method of ModelServer class #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serve#3190) * Fix serving runtime webhook cert namespace for kubeflow installation Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Generate CRD Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Fix qpext metrics port (kserve#3209) Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
… of lists (kserve#3229) * Fix lightbgm model input conversion when input is list of lists Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Fix cache key in CI Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
…rotocolVersion (kserve#3232) Fix runtime not found for triton due to wrong default protocolVersion Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Fix mlserver runtime priority for sklearn Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* CVE-2023-44487 core: Core dependencies update: x/net and grpc Signed-off-by: Spolti <fspolti@redhat.com> * CVE-2023-44487 - qpext (kserve#3203) [RHODS-12555] - CVE-2023-44487 - qpext Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Spolti <fspolti@redhat.com> Co-authored-by: Filippe Spolti <filippespolti@gmail.com>
* Version bump to 0.11.2 Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Updated v0.11.2 for the missing poetry projects. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> --------- Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Make storage initializer crd configurable Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Pin version of python to 3.11 since python 3.12 has removed support for distutils Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
…ver attribute exists before attempting to stop it. This prevents AttributeError when _rest_server attribute is not defined. This commit ensures robustness in stopping the model server components.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: serdarildercaglar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
serdarildercaglar
changed the title
|
@serdarildercaglar I think you need a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the
stopmethod in theModelServerclass to properly check if the_rest_serverattribute exists before attempting to stop it. This prevents AttributeError when_rest_serverattribute is not defined. This change ensures robustness in stopping the model server components.Which issue(s) this PR fixes:
Fixes #
Type of changes
Feature/Issue validation/testing:
Testing:
Logs: [Include relevant logs here]
Special notes for your reviewer:
Checklist:
Release note: