-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent AttributeError in stop method of ModelServer class #3538
Conversation
…serve#3190) * Fix serving runtime webhook cert namespace for kubeflow installation Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Generate CRD Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Fix qpext metrics port (kserve#3209) Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
… of lists (kserve#3229) * Fix lightbgm model input conversion when input is list of lists Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Fix cache key in CI Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
…rotocolVersion (kserve#3232) Fix runtime not found for triton due to wrong default protocolVersion Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Fix mlserver runtime priority for sklearn Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* CVE-2023-44487 core: Core dependencies update: x/net and grpc Signed-off-by: Spolti <fspolti@redhat.com> * CVE-2023-44487 - qpext (kserve#3203) [RHODS-12555] - CVE-2023-44487 - qpext Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Spolti <fspolti@redhat.com> Co-authored-by: Filippe Spolti <filippespolti@gmail.com>
* Version bump to 0.11.2 Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Updated v0.11.2 for the missing poetry projects. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> --------- Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Make storage initializer crd configurable Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Pin version of python to 3.11 since python 3.12 has removed support for distutils Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
…ver attribute exists before attempting to stop it. This prevents AttributeError when _rest_server attribute is not defined. This commit ensures robustness in stopping the model server components.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: serdarildercaglar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the PR title to reflect the actual changes in this PR?
@serdarildercaglar I think you need a rebase |
What this PR does / why we need it:
This PR updates the
stop
method in theModelServer
class to properly check if the_rest_server
attribute exists before attempting to stop it. This prevents AttributeError when_rest_server
attribute is not defined. This change ensures robustness in stopping the model server components.Which issue(s) this PR fixes:
Fixes #
Type of changes
Feature/Issue validation/testing:
Testing:
Logs: [Include relevant logs here]
Special notes for your reviewer:
Checklist:
Release note: