Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark kubectl-diff as implemented #1627

Merged
merged 2 commits into from Mar 24, 2020
Merged

Mark kubectl-diff as implemented #1627

merged 2 commits into from Mar 24, 2020

Conversation

apelisse
Copy link
Member

@apelisse apelisse commented Mar 23, 2020 •
edited

@apelisse apelisse mentioned this pull request Mar 23, 2020
Closed
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Mar 23, 2020
@apelisse
Copy link
Member Author

Fixes #491

@palnabarun
Copy link
Member

/lgtm

(on behalf of 1.18 Enhancements Team)

@palnabarun
Copy link
Member

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 23, 2020
@palnabarun
Copy link
Member

Thank you @apelisse

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2020
@palnabarun
Copy link
Member

/assign @pwittrock

(for approval)

@pwittrock
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, palnabarun, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit f156113 into kubernetes:master Mar 24, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.19 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@pwittrock pwittrock

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Kubectl Diff
4 participants
@apelisse @palnabarun @pwittrock @k8s-ci-robot