Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 3157 (watch-list): add a new ga criterion #4564

Closed
wants to merge 1 commit into from
Closed

KEP 3157 (watch-list): add a new ga criterion #4564

wants to merge 1 commit into from

Conversation

p0lyn0mial
Copy link
Contributor

  • One-line PR description: Adds an additional ga criterion for the WatchList feature.
  • Other comments: N/A

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Mar 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sttts March 28, 2024 14:25
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p0lyn0mial
Once this PR has been reviewed and has the lgtm label, please assign fedebongio for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 28, 2024
p0lyn0mial
p0lyn0mial commented Mar 28, 2024
View reviewed changes
keps/sig-api-machinery/3157-watch-list/README.md
@@ -680,12 +680,10 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
Knowing etcd configuration will be used to automatically disable the streaming feature.

#### GA
- Consider using WatchProgressRequester to request progress notifications directly from etcd.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to beta

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add that more explicitly to beta?

the detection of etcd isn't the same thing - we should have both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done, ptal.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2024
@p0lyn0mial
Copy link
Contributor Author

/assign @wojtek-t

sftim
sftim reviewed Apr 1, 2024
View reviewed changes
keps/sig-api-machinery/3157-watch-list/README.md Outdated
- [Switch](https://github.com/kubernetes/kubernetes/blob/a07b1aaa5b39b351ec8586de800baa5715304a3f/staging/src/k8s.io/apiserver/pkg/storage/cacher/cacher.go#L416)
the `storage/cacher` to use streaming directly from etcd
(This will also allow us to [remove](https://github.com/kubernetes/kubernetes/blob/a07b1aaa5b39b351ec8586de800baa5715304a3f/staging/src/k8s.io/client-go/tools/cache/reflector.go#L110) the `reflector.UseWatchList` field).
- Make LIST calls expensive in APF.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit

Suggested change
- Make LIST calls expensive in APF.
- Make **list** calls expensive in APF.

@wojtek-t
Copy link
Member

/lgtm

/assign @deads2k

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@p0lyn0mial
Copy link
Contributor Author

/close

in favour of #4605

@k8s-ci-robot
Copy link
Contributor

@p0lyn0mial: Closed this PR.

In response to this:

/close

in favour of #4605

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@sftim sftim sftim left review comments

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@deads2k deads2k

@wojtek-t wojtek-t

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p0lyn0mial @k8s-ci-robot @wojtek-t @sftim @deads2k