Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WG Serving mailing list #6758

Merged
merged 1 commit into from Apr 27, 2024
Merged

WG Serving mailing list #6758

merged 1 commit into from Apr 27, 2024
+57 −0

Conversation

SergeyKanzhelev
Copy link
Member

/sig apps

WG Serving mailing lists as per instructions.

Goes in combination with these two PRs:

More leads to be added after the first meeting

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 24, 2024
This was referenced Apr 26, 2024
Merged
Open
ArangoGutierrez
ArangoGutierrez approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@dims
Copy link
Member

dims commented Apr 27, 2024

@SergeyKanzhelev

terrytangyuan
User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@SergeyKanzhelev
Copy link
Member Author

@SergeyKanzhelev

terrytangyuan
User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

We fixed it already. I'll need to push some empty commit to clear it up. Will do later when at the computer. Thank you!

terrytangyuan
terrytangyuan approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Apr 27, 2024
ArangoGutierrez
ArangoGutierrez approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2024
@ArangoGutierrez
Copy link
Contributor

/assign dims

@dims
Copy link
Member

dims commented Apr 27, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, dims, SergeyKanzhelev, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1e5fd7c into kubernetes:main Apr 27, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@dims dims

@terrytangyuan terrytangyuan

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SergeyKanzhelev @dims @ArangoGutierrez @k8s-ci-robot @terrytangyuan