Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WG serving proposal #7823

Merged
merged 1 commit into from Apr 29, 2024
Merged

WG serving proposal #7823

merged 1 commit into from Apr 29, 2024
+200 −0

Conversation

SergeyKanzhelev
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev commented Apr 16, 2024 •
edited

Which issue(s) this PR fixes:

See the thread for context: https://groups.google.com/g/kubernetes-sig-architecture/c/-DvFBA0805k

/sig apps
/sig architecture
/sig node
/sig scheduling
/sig autoscaling
/sig network
/sig instrumentation
/sig storage

/cc @smarterclayton

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. committee/steering Denotes an issue or PR intended to be handled by the steering committee. labels Apr 16, 2024
@ArangoGutierrez
Copy link
Contributor

++

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Apr 17, 2024
ArangoGutierrez
ArangoGutierrez reviewed Apr 17, 2024
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
wg-serving/charter.md Outdated Show resolved Hide resolved
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Apr 17, 2024
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Apr 20, 2024
Merged
@SergeyKanzhelev SergeyKanzhelev force-pushed the serving-charter branch 2 times, most recently from 49e6111 to 7d151bc Compare April 22, 2024 19:27
helayoty
helayoty reviewed Apr 22, 2024
View reviewed changes
sig-list.md Outdated Show resolved Hide resolved
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Apr 24, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2024
ArangoGutierrez
ArangoGutierrez reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @SergeyKanzhelev @smarterclayton @klueska

sigs.yaml Outdated Show resolved Hide resolved
OWNERS_ALIASES Outdated Show resolved Hide resolved
wg-serving/README.md Outdated Show resolved Hide resolved
@SergeyKanzhelev SergeyKanzhelev force-pushed the serving-charter branch 2 times, most recently from 3e24def to 9535815 Compare April 26, 2024 20:36
terrytangyuan
terrytangyuan approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented Apr 26, 2024 •
edited

Steering votes counting:

ArangoGutierrez
ArangoGutierrez approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pacoxu
pacoxu reviewed Apr 28, 2024
View reviewed changes
sigs.yaml
frequency: weekly
url: https://zoom.us/j/93517402529?pwd=RnkwUUQ4L3J2QmNYYlNBcnZGbXcvQT09
archive_url: https://docs.google.com/document/d/1aExJFtaLnO-TM6_2uILgI8NI0IjOm7FcwLABBKEMEo0/edit
recordings_url: https://www.youtube.com/playlist?list=TODO
Copy link
Member

@pacoxu pacoxu Apr 28, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have one record in https://www.youtube.com/watch?v=Ri4rQNoRBko. Can we create a playlist for the wg?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested creation of YouTube playlist as per #7850 on Friday - sent Slack message to YouTube maintainer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the WG Serving playlist:
https://www.youtube.com/playlist?list=PL69nYSiGNLP30qNanabU75ayPK7OPNAAS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, added it here: #7862

pacoxu
pacoxu approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

palnabarun
palnabarun approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits here and there. They can be taken in a follow up too if needed.

/lgtm
(on the charter with the steering hat)

wg-serving/charter.md Outdated Show resolved Hide resolved
wg-serving/charter.md Outdated Show resolved Hide resolved
wg-serving/charter.md Outdated Show resolved Hide resolved
wg-serving/charter.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
@mrbobbytables mrbobbytables self-requested a review April 29, 2024 20:37
@terrytangyuan
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
BenTheElder
BenTheElder reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, BenTheElder, mrbobbytables, pacoxu, palnabarun, SergeyKanzhelev, soltysh, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,mrbobbytables,pacoxu,palnabarun,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SergeyKanzhelev
Copy link
Member Author

Thank you everybody reviewed this! If there are any additional feedback, please do not hesitate to reach out to me.

Quorum on steering votes was reached: #7823 (comment)

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@SergeyKanzhelev
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3be7aca into kubernetes:master Apr 29, 2024
3 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@pnbrown pnbrown pnbrown left review comments

@kerthcet kerthcet kerthcet left review comments

@helayoty helayoty helayoty left review comments

@soltysh soltysh soltysh approved these changes

@pacoxu pacoxu pacoxu approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@mrbobbytables mrbobbytables mrbobbytables approved these changes

@palnabarun palnabarun palnabarun approved these changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@BenTheElder BenTheElder

@pacoxu pacoxu

@terrytangyuan terrytangyuan

@palnabarun palnabarun

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
SIG Scheduling
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet