Dry-run: Path to GA

[apelisse]

This is describing the steps necessary to move Dry-run to Beta.

These are the list of features and bugs that need to be addressed before Dry-run can move to GA.

Please cross-out (do not remove, please) whichever does not seem appropriate for moving to GA and put your name behind it. If you want to add any notes specific to a task, please list it as a bullet point and again, put your name behind it.

Features

• Beta: Change flag from Alpha to Beta and default to enable dry-run: Promote from Alpha to Beta #69644 @apelisse
• Beta: Update documentation @apelisse
• GA: Add prometheus metrics for dry-run (Track dry-run and apply in metrics #74997, needs to be cherry-picked to 1.13)
• GA: Change default for SideEffect in admissionregistration Webhook v1 #68839 Change default for SideEffect in admissionregistration Webhook @apelisse
• GA: Implement consistent server-side "dry-run" flag on Kubectl @julianvmodesto Support apiserver dry-run in kubectl #85652 Update dry-run KEP with kubectl plan enhancements#1399
• GA: Add dry-run support in client-go @apelisse @lavalamp
• GA: Document dry-run requires write access (and so does kubectl diff as a consequence)

Bugs

• pods/eviction does not honor dryRun: trueoption pods/eviction does not honor dryRun: trueoption #76943: Fix eviction dry-run #76969
• cherry-pick Fix eviction dry-run #76969 to 1.13 and 1.14

Tech Debt

• Create an integration test suite for dry-run sub-resources Create an integration test suite for dry-run sub-resources #76971

[apelisse]

/sig api-machinery

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[apelisse]

/lifecycle frozen

[apelisse]

Let's finish these two tasks and close that issue. Planned for 1.18.

[julianvmodesto]

It's probably a good idea to document that if an apiserver doesn't know about dry-run, then a request would write to storage anyway so dry-run users need to check for dry-run support.

[lavalamp]

I think that hasn't been true since 1.11?

…

On Thu, Jan 16, 2020, 5:27 PM Julian V. Modesto ***@***.***> wrote: It's probably a good idea to document that if an apiserver doesn't know about dry-run, then a request would write to storage anyway so dry-run users need to check for dry-run support. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68514?email_source=notifications&email_token=AAE6BFRNIVJV3HTSAHJK3NDQ6ECQBA5CNFSM4FUPAXFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGEKXI#issuecomment-575423837>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE6BFVJU7QUKNJTDADHOF3Q6ECQBANCNFSM4FUPAXFA> .

[apelisse]

Correct, 9861392.

It's two years old, and I don't think we do support these versions anymore (security patch etc, AFAIK).

[julianvmodesto]

Doc task #86526

[julianvmodesto]

I don't think kubectl scale --dry-run is blocking GA, so we seem covered here for addressing features, bugs, and testing before code freeze and only have the docs left.

[julianvmodesto]

Actually one last change to merge: #88133

[apelisse]

Only thing left now is updating the documentation.

[julianvmodesto]

Looks like we're done here!

Follow ups are being tracked in these issues:

• umbrella APIServer DryRun enhancements#576
• Create an integration test suite for dry-run sub-resources #76971
• Add --dry-run=server|client to kubectl scale #88740

[julianvmodesto]

/close

[k8s-ci-robot]

@julianvmodesto: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[apelisse]

Sweet!