exec credential provider: handle wrapped exec errors #103772

ankeesler · 2021-07-19T13:36:47Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

The updated code now handles cases where running an exec plugin fails with wrapped errors.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: External client-go credential providers enhancements#541

k8s-ci-robot · 2021-07-19T13:36:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankeesler
To complete the pull request process, please assign mikedanese after the PR has been reviewed.
You can assign the PR to them by writing /assign @mikedanese in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ankeesler · 2021-07-19T13:37:07Z

/sig auth
/cc @enj
/remove-sig api-machinery

ankeesler · 2021-07-19T13:38:14Z

staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go

 		)

+	case os.IsPermission(err):
+		return fmt.Errorf("exec: binary %s not executable", a.cmd)


I'm not in love with changing this error message to say "binary" instead of "executable" (because the plugin could be a bash script, which I would not consider to be a binary), but I wanted to avoid the redundancy of the error message "executable blah is not executable". Any suggestions?

A new unit test message binary ./testdata/not-executable.sh not executable seems a little odd as @ankeesler pointed at the above.
How about keeping "executable" for the other places and removing "executable" from the above case os.IsPermission only to avoid unnecessary confusions?

ankeesler · 2021-07-19T13:38:44Z

staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go

 		)

+	case os.IsPermission(err):


Is this how you were hoping to use os.IsPermission()?

ankeesler · 2021-07-19T13:39:51Z

staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go

+	execError := &exec.Error{}
+	exitError := &exec.ExitError{}
+	switch {
+	case errors.As(err, &execError): // Binary does not exist (see exec.Error).


I couldn't figure out how to work in os.IsNotExist() here. I tried both errors.As(err, &execError) && os.IsNotExist(err) and errors.As(err, &execError) && os.IsNotExist(execError), but these logical expressions never evaluated to true for me.

Signed-off-by: Andrew Keesler <akeesler@vmware.com>

fedebongio · 2021-07-20T20:12:01Z

/remove-sig api-machinery

enj · 2021-07-22T12:36:36Z

I think this is a small enough issue that can wait until 1.23.

/triage accepted
/priority important-longterm
/assign
/milestone v1.23

jyotimahapatra · 2021-09-22T03:25:11Z

Hi 👋 I'm the bug triage shadow. I wanted to check in and see if this PR is targeted for milestone 1.23 .

ankeesler · 2021-09-27T13:28:15Z

@jyotimahapatra sure! That would be great if we could target this at 1.23

jyotimahapatra · 2021-10-27T01:02:11Z

@ankeesler Im checking in again to check if we can coordinate with sig auth to get this PR approved and merge this in 1.23 time frame

ankeesler · 2021-10-28T12:37:28Z

@jyotimahapatra - sorry for the delay. i am having trouble finding time to devote to kube currently, but i think this pr seems small enough. i wonder if @enj would be able to review this for 1.23?

enj · 2021-11-17T01:27:45Z

/milestone v1.24

Ran out of time in 1.23

dims · 2022-01-04T22:49:06Z

@enj @ankeesler what more does this need?

/retest

k8s-ci-robot · 2022-01-04T23:26:47Z

@ankeesler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-integration	`b8fb5f3`	link	true	`/test pull-kubernetes-integration`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

enj · 2022-01-05T17:56:39Z

@enj @ankeesler what more does this need?

It is on my list of things to review in 1.24

jyotimahapatra · 2022-02-09T03:06:46Z

Hi 👋 I'm checking in from the bug triage team for release 1.24. Is this PR targeted for release 1.24?

jyotimahapatra · 2022-03-16T05:22:17Z

Hi @enj 👋 I'm from bug triage team. I wanted to check if we're tracking this for milestone 1.24.

enj · 2022-03-28T20:48:28Z

I will try to review this for 1.24 but this does not block the release.

/milestone v1.25

oomichi

/cc @oomichi

oomichi · 2022-04-12T21:23:42Z

staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go

 		)

+	case os.IsPermission(err):
+		return fmt.Errorf("exec: binary %s not executable", a.cmd)


A new unit test message binary ./testdata/not-executable.sh not executable seems a little odd as @ankeesler pointed at the above.
How about keeping "executable" for the other places and removing "executable" from the above case os.IsPermission only to avoid unnecessary confusions?

k8s-triage-robot · 2022-07-11T22:12:10Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-08-10T23:10:00Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

helayoty · 2022-08-15T13:58:02Z

/milestone clear

k8s-triage-robot · 2022-09-14T14:19:32Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-09-14T14:19:38Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from deads2k and johnSchnake July 19, 2021 13:36

k8s-ci-robot requested a review from enj July 19, 2021 13:37

k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 19, 2021

ankeesler commented Jul 19, 2021

View reviewed changes

exec credential provider: handle wrapped exec errors

b8fb5f3

Signed-off-by: Andrew Keesler <akeesler@vmware.com>

ankeesler force-pushed the fix-error-usage branch from ff74cc3 to b8fb5f3 Compare July 19, 2021 14:32

k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 19, 2021

enj added this to Needs Triage in SIG Auth Old Jul 19, 2021

k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 20, 2021

k8s-ci-robot assigned enj Jul 22, 2021

k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 22, 2021

k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 22, 2021

enj moved this from Needs Triage to In Review (v1.22) in SIG Auth Old Jul 22, 2021

k8s-ci-robot modified the milestones: v1.23, v1.24 Nov 17, 2021

k8s-ci-robot modified the milestones: v1.24, v1.25 Mar 28, 2022

oomichi reviewed Apr 12, 2022

View reviewed changes

k8s-ci-robot requested a review from oomichi April 12, 2022 21:26

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 10, 2022

k8s-ci-robot removed this from the v1.25 milestone Aug 15, 2022

k8s-ci-robot closed this Sep 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

exec credential provider: handle wrapped exec errors #103772

exec credential provider: handle wrapped exec errors #103772

ankeesler commented Jul 19, 2021

k8s-ci-robot commented Jul 19, 2021

ankeesler commented Jul 19, 2021

ankeesler Jul 19, 2021

oomichi Apr 12, 2022

ankeesler Jul 19, 2021

ankeesler Jul 19, 2021 •

edited

fedebongio commented Jul 20, 2021

enj commented Jul 22, 2021

jyotimahapatra commented Sep 22, 2021

ankeesler commented Sep 27, 2021

jyotimahapatra commented Oct 27, 2021

ankeesler commented Oct 28, 2021

enj commented Nov 17, 2021

dims commented Jan 4, 2022

k8s-ci-robot commented Jan 4, 2022

enj commented Jan 5, 2022

jyotimahapatra commented Feb 9, 2022

jyotimahapatra commented Mar 16, 2022

enj commented Mar 28, 2022

oomichi left a comment

oomichi Apr 12, 2022

k8s-triage-robot commented Jul 11, 2022

k8s-triage-robot commented Aug 10, 2022

helayoty commented Aug 15, 2022

k8s-triage-robot commented Sep 14, 2022

k8s-ci-robot commented Sep 14, 2022

exec credential provider: handle wrapped exec errors #103772

exec credential provider: handle wrapped exec errors #103772

Conversation

ankeesler commented Jul 19, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Jul 19, 2021

ankeesler commented Jul 19, 2021

ankeesler Jul 19, 2021

Choose a reason for hiding this comment

oomichi Apr 12, 2022

Choose a reason for hiding this comment

ankeesler Jul 19, 2021

Choose a reason for hiding this comment

ankeesler Jul 19, 2021 • edited

Choose a reason for hiding this comment

fedebongio commented Jul 20, 2021

enj commented Jul 22, 2021

jyotimahapatra commented Sep 22, 2021

ankeesler commented Sep 27, 2021

jyotimahapatra commented Oct 27, 2021

ankeesler commented Oct 28, 2021

enj commented Nov 17, 2021

dims commented Jan 4, 2022

k8s-ci-robot commented Jan 4, 2022

enj commented Jan 5, 2022

jyotimahapatra commented Feb 9, 2022

jyotimahapatra commented Mar 16, 2022

enj commented Mar 28, 2022

oomichi left a comment

Choose a reason for hiding this comment

oomichi Apr 12, 2022

Choose a reason for hiding this comment

k8s-triage-robot commented Jul 11, 2022

k8s-triage-robot commented Aug 10, 2022

helayoty commented Aug 15, 2022

k8s-triage-robot commented Sep 14, 2022

k8s-ci-robot commented Sep 14, 2022

ankeesler Jul 19, 2021 •

edited