Pass the CA root cert into the apiserver #7326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perform client cert checks for authorization. Only enable on GCE where the apiserver is terminating SSL connections from end users.
|
/cc @lavalamp |
|
@zmerlynn I'd like for this to get in before the 0.16.0 release cut tomorrow if possible. Thanks! |
|
Sorry, was completely offline. Looking now. |
|
LGTM |
zmerlynn
added a commit
that referenced
this pull request
Apr 27, 2015
Pass the CA root cert into the apiserver
|
Thanks for finding! |
| @@ -43,10 +43,12 @@ | |||
|
|
|||
| {% set cert_file = "--tls_cert_file=/srv/kubernetes/server.cert" -%} | |||
| {% set key_file = "--tls_private_key_file=/srv/kubernetes/server.key" -%} | |||
| {% set client_ca_file = "--client_ca_file=/dev/null" -%} | |||
There was a problem hiding this comment.
This broke non-GCE providers I think. Right now, the kube-apiserver outputs errors like the following:
F0427 21:05:35.065323 1 server.go:247] Invalid Authentication Config: error reading /dev/null: could not read any certificatesIs there any reason why we could not default the value to the empty string?
{% set client_ca_file = "" -%}
There was a problem hiding this comment.
I will put a PR together that does what described above.
There was a problem hiding this comment.
Sorry @derekwaynecarr. I was following the example of the token auth file since I thought the implementation on the server was identical.
derekwaynecarr
added a commit
to derekwaynecarr/kubernetes
that referenced
this pull request
Apr 27, 2015
a-robinson
added a commit
that referenced
this pull request
Apr 27, 2015
Fix vagrant regression due to #7326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the apiserver will perform client cert checks for authorization. Only enable on GCE where
the apiserver is terminating SSL connections from end users.