Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #82384: Reorder symlinks to prevent path escapes #82503

Merged
merged 1 commit into from Sep 11, 2019
Merged

Automated cherry pick of #82384: Reorder symlinks to prevent path escapes #82503

merged 1 commit into from Sep 11, 2019

Conversation

tallclair
Copy link
Member

@tallclair tallclair commented Sep 9, 2019 •
edited

Cherry pick of #82384 on release-1.13.

#82384: Reorder symlinks to prevent path escapes

kubectl cp now safely allows unpacking of symlinks that may point outside the destination directory

/sig cli
/kind bug

@k8s-ci-robot
Copy link
Contributor

@tallclair: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please ping the kubernetes/patch-release-team in a comment when ready.

See also Kubernetes Patch Releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 9, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Sep 9, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 9, 2019
@tallclair
Copy link
Member Author

Wait for #82384 to merge
/hold

/cc @tpepper

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2019
soltysh
soltysh approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2019
@soltysh
Copy link
Contributor

soltysh commented Sep 10, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 10, 2019
@tpepper
Copy link
Member

tpepper commented Sep 11, 2019

The 1.15 branch #82384 has merged
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit dc0c670 into kubernetes:release-1.13 Sep 11, 2019
sallyom added a commit to sallyom/origin that referenced this pull request Oct 8, 2019
@sallyom
Bug 1753501: UPSTREAM: 82503
33d9014 
This is a manual pick of kubernetes/kubernetes#82503
Reorder symlinks to prevent path escapes
@sallyom sallyom mentioned this pull request Oct 8, 2019
Merged
sallyom added a commit to sallyom/origin that referenced this pull request Oct 8, 2019
@sallyom
Bug 1753500: UPSTREAM: 82503
09b2da8 
This is a manual pick of kubernetes/kubernetes#82503
Reorder symlinks to prevent path escapes
@sallyom sallyom mentioned this pull request Oct 8, 2019
Merged
sallyom added a commit to sallyom/origin that referenced this pull request Oct 9, 2019
@sallyom
UPSTREAM: 82503: Bug 1753500
1e6383a 
This is a manual pick of kubernetes/kubernetes#82503
Reorder symlinks to prevent path escapes
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Oct 14, 2019
@sallyom @k8s-publishing-bot
UPSTREAM: 82503: Bug 1753500
6e4f6a8 
This is a manual pick of kubernetes#82503
Reorder symlinks to prevent path escapes

Origin-commit: 1e6383ace12f0b6d26ea204e9e440b3b8a967450
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Oct 15, 2019
@sallyom @k8s-publishing-bot
Bug 1753501: UPSTREAM: 82503
d1a3e36 
This is a manual pick of kubernetes#82503
Reorder symlinks to prevent path escapes

Origin-commit: 33d90141c70c8dcd3110391690ab86a1668dcde8
@liggitt liggitt mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@tpepper tpepper Awaiting requested review from tpepper

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tallclair @k8s-ci-robot @soltysh @tpepper