Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Cp 1.15 #82384
What type of PR is this?
What this PR does / why we need it:
This greatly simplifies the symlink resolution logic, and is robust to corner cases we have missed in the past.
Special notes for your reviewer:
Please review carefully. This is changing a bunch of logic that we've had a lot of issues with in the past.
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Valid question, but IMO we shouldn't worry about this case.
1 similar comment