Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on CRUD operations on RuntimeClasses API #96551

Merged
merged 1 commit into from Nov 14, 2020
Merged

Test on CRUD operations on RuntimeClasses API #96551

merged 1 commit into from Nov 14, 2020

Conversation

SergeyKanzhelev
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev commented Nov 13, 2020 •
edited

What type of PR is this?

/kind cleanup
/kind regression
/sig node

What this PR does / why we need it:
This PR added a test to be promoted to conformance that exercise all CRUD operations of RuntimeClasses API.

Which issue(s) this PR fixes:
Related #96524

(The follow up PR that will promote the test to conformance will fix it)

Special notes for your reviewer:
Added comments needed for conformance, but keep it regular test for presubmits to run it.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 13, 2020
@SergeyKanzhelev
Copy link
Member Author

Test passes

I1113 09:11:42.088] [It]  [NodeConformance] should support RuntimeClasses API operations
I1113 09:11:42.089]   /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/common/runtimeclass.go:100
I1113 09:11:42.089] �[1mSTEP�[0m: getting /apis
I1113 09:11:42.089] �[1mSTEP�[0m: getting /apis/node.k8s.io
I1113 09:11:42.089] �[1mSTEP�[0m: getting /apis/certificates.k8s.io/v1
I1113 09:11:42.089] �[1mSTEP�[0m: creating
I1113 09:11:42.089] �[1mSTEP�[0m: watching
I1113 09:11:42.089] Nov 13 09:07:25.326: INFO: starting watch
I1113 09:11:42.089] �[1mSTEP�[0m: getting
I1113 09:11:42.089] �[1mSTEP�[0m: listing
I1113 09:11:42.090] �[1mSTEP�[0m: patching
I1113 09:11:42.090] �[1mSTEP�[0m: updating
I1113 09:11:42.090] Nov 13 09:07:25.350: INFO: waiting for watch events with expected annotations
I1113 09:11:42.090] �[1mSTEP�[0m: deleting
I1113 09:11:42.090] �[1mSTEP�[0m: deleting a collection
I1113 09:11:42.090] [AfterEach] [sig-node] RuntimeClass

@SergeyKanzhelev
Copy link
Member Author

CC: @hh, @liggitt

Should the process be merging it first and after that if it passes for a few days, send another PR that will change it to Conformance?

SergeyKanzhelev
SergeyKanzhelev commented Nov 13, 2020
View reviewed changes
test/e2e/common/runtimeclass.go
The runtimeclasses resource MUST exist in the /apis/node.k8s.io/v1 discovery document.
The runtimeclasses resource must support create, get, list, watch, update, patch, delete, and deletecollection.
*/
ginkgo.It(" [NodeConformance] should support RuntimeClasses API operations", func() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping it as a regular test for now. Also added [NodeConformance] so it will run during the PR validation

@hh
Copy link
Member

hh commented Nov 13, 2020

Merge first, then we will need a separate promotion PR with the conformance metadata.

@jeremyrickard
Copy link
Contributor

Exception request: https://groups.google.com/g/kubernetes-sig-node/c/UhZ7JgaeZPE
Exception Granted: Nov 13
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 13, 2020
@SergeyKanzhelev
Copy link
Member Author

/test pull-kubernetes-bazel-test

tallclair
tallclair reviewed Nov 14, 2020
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

To unblock RuntimeClass to GA. It still strikes me as odd that we need to write out these tests in full, so we should make sure to deduplicate these in the future.

test/e2e/common/runtimeclass.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2020
@dchen1107
Copy link
Member

dchen1107 commented Nov 14, 2020 •
edited

/lgtm
/approve

Agree with @tallclair above. On another hand, I hope the pr can move forward, so that the test can run over the weekend. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, SergeyKanzhelev, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0913f8a into kubernetes:master Nov 14, 2020
@SergeyKanzhelev SergeyKanzhelev deleted the runtimeclassconformance branch November 14, 2020 01:42
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@derekwaynecarr derekwaynecarr derekwaynecarr left review comments

@tallclair tallclair tallclair left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@dchen1107 dchen1107

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@SergeyKanzhelev @k8s-ci-robot @hh @jeremyrickard @dchen1107 @mrunalp @derekwaynecarr @tallclair