Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use buildDate to access web static build version #1950

Merged
merged 3 commits into from Mar 5, 2024
Merged

fix: Use buildDate to access web static build version #1950

merged 3 commits into from Mar 5, 2024

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Mar 5, 2024 •
edited

This PR is a follow-up to lablup/backend.ai-webui#2072.

Before After
image image

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@rapsealk rapsealk added this to the 23.09 milestone Mar 5, 2024
@rapsealk rapsealk requested a review from achimnol March 5, 2024 02:17
@rapsealk rapsealk self-assigned this Mar 5, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Mar 5, 2024
@achimnol achimnol added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 369490c Mar 5, 2024
27 checks passed
@achimnol achimnol deleted the fix/update-web-static-build-date branch March 5, 2024 06:24
kyujin-cho pushed a commit that referenced this pull request Mar 5, 2024
@rapsealk @kyujin-cho
fix: Use buildDate to access web static build version (#1950)
5bd2602 
Backported-from: main
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol approved these changes

Assignees

@rapsealk rapsealk

Labels
size:XS ~10 LoC
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rapsealk @achimnol