Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use buildDate to access web static build version #1950

Merged
merged 3 commits into from Mar 5, 2024
Merged

fix: Use buildDate to access web static build version #1950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b792417
fix: Update to use `buildDate` than outdated `build`
rapsealk Mar 5, 2024
7504784
docs: Rename the news fragment with the PR number
rapsealk Mar 5, 2024
87bacfb
Merge branch 'main' into fix/update-web-static-build-date
rapsealk Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/1950.fix.md
View file
Open in desktop
@@ -0,0 +1 @@
Use `buildDate` instead of `build` to retrieve web static version to follow lablup/backend.ai-webui#2072
2 changes: 1 addition & 1 deletion scripts/install-dev.sh
View file
Open in desktop
Expand Up @@ -937,7 +937,7 @@ configure_backendai() {
install_editable_webui
sed_inplace "s@\(#\)\{0,1\}static_path = .*@static_path = "'"src/ai/backend/webui/build/rollup"'"@" ./webserver.conf
else
webui_version=$(jq -r '.package + " (built at " + .build + ", rev " + .revision + ")"' src/ai/backend/web/static/version.json)
webui_version=$(jq -r '.package + " (built at " + .buildDate + ", rev " + .revision + ")"' src/ai/backend/web/static/version.json)
show_note "The currently embedded webui version: $webui_version"
fi

Expand Down