[5.8] Document some 5.8 breaking changes #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Coder264
force-pushed
the
document-5.8-breaking-changes
branch
from
8caf7d9
to
008ae36
Compare
X-Coder264
force-pushed
the
document-5.8-breaking-changes
branch
from
008ae36
to
d0ae794
Compare
driesvints
requested changes
Jan 11, 2019
|
|
||
| The `send`, `sendNow`, `queue`, `later` and `fill` methods of the `Illuminate\Mail\PendingMail` class [have been changed](https://github.com/laravel/framework/pull/26790) to accept an `Illuminate\Contracts\Mail\Mailable` instance instead of `Illuminate\Mail\Mailable`. If you are overriding some of these methods, you should update their signature to match its parent. | ||
|
|
||
| #### Method Name Change In The `Markdown` Class |
There was a problem hiding this comment.
It's best that this gets a higher impact because the folder name was changed again and everyone who has published the files to the view folder will need to rename the markdown folder to text.
There was a problem hiding this comment.
I agree, but Taylor already merged it before I had the time to change it so I guess he'll take care of it :)
|
Thanks for sending this in btw 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents laravel/framework#26754, laravel/framework#26790, laravel/framework#26898, laravel/framework#26908, laravel/framework#26938, laravel/framework#26953, laravel/framework#27067, laravel/framework#26985 and laravel/framework#27066