Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] PHP 8.0 fix for Closure jobs #46505

Merged
merged 2 commits into from Mar 17, 2023
Merged

Conversation

bert-w
Copy link
Contributor

@bert-w bert-w commented Mar 17, 2023

Fixes #46355 (passing a Closure would fail because isset($closure->someProperty) throws an error on PHP 8.0).

@bert-w bert-w marked this pull request as ready for review March 17, 2023 17:54
@bert-w
Copy link
Contributor Author

bert-w commented Mar 17, 2023

sometimes I feel like there are little gnomes that cause the tests to fail

@taylorotwell taylorotwell merged commit e081830 into laravel:9.x Mar 17, 2023
19 checks passed
@bert-w bert-w deleted the fix-closure-job branch March 17, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants