Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Removes unnecessary creatable API singleton parameter #46677

Merged

Conversation

drradao
Copy link
Contributor

@drradao drradao commented Apr 3, 2023

Issue

Currently the creatable() and destroyable() methods in an API singleton resource route registartion accept boolean parameters that aren't taken into consideration later.

Route::apiSingleton('route', Controller::class)
    ->creatable()
    ->destroyable();

Possible solution

Removal of these parameters as suggested here

@GrahamCampbell
Copy link
Member

This is strictly speaking a breaking change, so should go to master. In any case this is not a bug fix, so 9.x would not be appropriate.

@GrahamCampbell
Copy link
Member

Oh, catching up on the other PR. I guess this is a bug fix. ;)

@drradao
Copy link
Contributor Author

drradao commented Apr 3, 2023

I guess it could be breaking if someone is passing a value there...

We could also add a comment in the parameter stating that the feature isn't there so people don't spam the optimize:clear command like maniacs thinking that they're cached 😄

@taylorotwell taylorotwell merged commit c0d09c5 into laravel:9.x Apr 4, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants