New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support current and future FreeBSD releases #985
Conversation
Also removed some unnecessary imports. This closes matplotlib#225
I did consider this approach but I stuck to the explicit OS-es (safer bet) as I figured that, had the original author of setupext wanted to support every OS up-front they would have done so. That logic may not be sound as its likely that the number of supported OS-es has gradually increased rather than all of them being known up-front. It is worth noting that this change in approach means that a user of AIX6 will now get paths that have been explicitly removed for AIX5 rather than a KeyError. I'm not sure which is worse :-) . |
I just dislike having a ton of copy-pasted lines for each FreeBSD release that is identical, so that our hand is otherwise forced to have to update this file on every new OS release. There are also lots of comments here about how we should not be using As for AIX6, we'll fix that issue when (if) it gets reported ;) For example, NetBSD was never included in the original basedir dictionary that was there, but they have a (presumably working) port that just patches up 'basedirlist' in the place it matters (they apparently disabled extensions, and did not need to patch it in |
Agreed. But something like
I don't have a problem with this approach, but to be completely explicit, this was not how For what its worth, this approach has my +1, but take that with a pinch of salt as I don't know the original motivation for limiting setupext to fixed OS-es in the first place. |
Yeah, this makes sense to me. From reading portions of Python Bug #12326, it seems like we should not have been using Let's give it another day before merging... |
sounds good, @pelson. There's 6 more hours before your proposed deadline, so I'll probably be asleep, but feel free to go ahead with the merge |
Support current and future FreeBSD releases in the setupext.py build script.
Also removed some unnecessary imports. This closes #225
This is an alternative to #982, and I consider this PR to be more future-proof. As I explain in the comments:
Implementation detail: I checked and
defaultdict
was introduced into collections at 2.5, so we're safe, since trunk no longer need to be 2.4 compatible.