Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hist for log=True and histtype='step' #1684

Merged
merged 6 commits into from Jan 27, 2013

Conversation

dmcdougall
Copy link
Member

Rebased version of #1029 to target v1.2.x. This aims to fix #196 but is currently incomplete.

@dmcdougall
Copy link
Member Author

Over in #1029 there was discussion of using the log's actual base rather than the magical number 0.1. This would be the correct solution aside from the fact that the axis scale is set to base ten inside hist (it's the default). If the user then changes the [xy]scale outside of hist, how do we change the plot to reflect the change of base without calling hist again?

@WeatherGod
Copy link
Member

I wouldn't worry too much about a situation where the log base changes
after the call to hist. A lot of stuff breaks if you do any sort of
rescaling after the call to hist, and if it isn't already, it should be
well documented to establish your scales prior to any plotting.

@dmcdougall
Copy link
Member Author

@WeatherGod Alright, thanks for that information.

Are there any other concerns that need to be addressed before this is merged? All tests pass locally on python 2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants