Fixed hatch clipping. #2001
Closed
Fixed hatch clipping. #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaces #1898 |
|
👍 Seems like a pretty straightforward fix. Can you rebase this against |
|
I've just done this locally, but the test results change (because of the color handling added recently on master). For example with v1.2.x: The svg rendering of one of the images in this PR looks like: On this basis, I'm not sure its worth the extra overhead of putting it against Thoughts? |
|
We can put different test images on each branch. I think better that than to have hatches continue to be broken. I'd like to put out a rock-solid 1.2.2 around the same time as 1.3.0... |
Merged
I can't refuse a reasonable request 😄 - #2003 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.