Create a temporary bitmap context if needed #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but I don't have a mac to test this. attn @jenshnielsen @pelson |
|
Fixes it for me. |
jenshnielsen
added a commit
that referenced
this pull request
Aug 8, 2015
Create a temporary bitmap context if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2654. Usually get_text_width_height_descent is called as part of figure.draw, and then the graphics context is available to measure the text in. If get_text_width_height_descent is called as part of tight_layout instead of figure.draw, then no graphics context is available. But since we are only measuring text and not actually drawing anything, we can create a temporary bitmap context and measure the text there.