Support generative tests in @cleanup.

[anntzer]

All's in the title.

[anntzer]

Rebased #5785 onto this, just to show that this implementation works.

[tacaswell]

👍 that is way simpler than I expected it to be!

[anntzer]

Hum... I am pretty sure that the cleanup decorator (in its old version) made nose silently skip test_axes.test_remove_shared_axes (the single failing test), which has then been (effectively) broken in some later commit. Can you investigate?

[tacaswell]

Huh, good catch. I will try to take a look at that tomorrow.

[mdboom]

Thanks. We were just talking about this in #5718.

[tacaswell]

I do not have a clear memory of writing that test (but git blame tells me I did!). Sometimes I work in a tdd style where I just run the tests to check things so that test may have never worked.

For expediency of getting this merged, maybe throw a KnownFail on this create an issue telling me to fix the test.

[anntzer]

Done. By the way, why was the previous AppVeyor build successful even though the test suite failed? (I am a bit confused.)

[anntzer]

I am even more confused by the new test failure. Anyone wants to take over this PR? (TBH I have little interest in investigating this.)

[tacaswell]

Did you run these locally? That error is what happens if the test module is not importable.

[tacaswell]

Turns out the fix is trivial, there is just an extra assert before the assert_array_equal. The function was not raising, so returning None which fails the assert.

[tacaswell]

I am going to do some local git merging to:

• drop the second commit of this PR
• add a commit to fix the test
• backport the whole thing to v1.5.x

[tacaswell]

Actually, I am having issues getting this to pass locally and am getting a large number of file not closed warnings, see anntzer#1

[anntzer]

Actually my original patch was wrong... can you see why? It's fixed now.

[tacaswell]

backported to v2.x as 80be853