Make @cleanup *really* support generative tests. #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
'power cycled' to re-trigger build against new master. |
tacaswell
added a commit
that referenced
this pull request
Feb 18, 2016
Make @cleanup *really* support generative tests.
|
Merging as I do not think the close/open cycle restarts appveyor. |
|
Does this need to be backported to 2.x? |
|
#5809 is actually milestoned to be on 1.5.2, though I'm not seeing it. |
|
This should be backported if we want to get #5785 into 2.x, no? |
tacaswell
added a commit
that referenced
this pull request
Mar 26, 2016
Make @cleanup *really* support generative tests.
tacaswell
modified the milestones:
2.0 (style change major release),
2.1 (next point release)
bearstrong
pushed a commit
to bearstrong/matplotlib
that referenced
this pull request
Apr 1, 2016
…sts-again Make @cleanup *really* support generative tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generative tests were still not run after #5809. If
fis defined asdef f(): yield,isgeneratorfunction(f) == isgenerator(f()) == True.