Skip to content

Fixed path caching bug in Path.unit_regular_star #6697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2016
Merged

Fixed path caching bug in Path.unit_regular_star #6697

merged 1 commit into from
Jul 6, 2016

Conversation

Kojoley
Copy link
Member

@Kojoley Kojoley commented Jul 6, 2016

No description provided.

@Kojoley
Copy link
Member Author

Kojoley commented Jul 6, 2016

Any reason for implementing cache with WeakValueDictionary? I see no problem just to use dict here.
I think this place is where functools.lru_cache decorator can be used (but with some python 2 fallback)

@mdboom
Copy link
Member

mdboom commented Jul 6, 2016

👍 from me

@tacaswell tacaswell merged commit 3590ce2 into matplotlib:master Jul 6, 2016
@tacaswell
Copy link
Member

Thanks!

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jul 6, 2016
@Kojoley Kojoley deleted the fix-path-cache-in-unit_regular_star branch July 12, 2016 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Kojoley @mdboom @tacaswell @QuLogic