New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text box widget, take over of PR5375 #6988
Conversation
@tacaswell here is the new PR, I just discover a small bug
I will try to fix it next week @Nodraak can you submit a PR against this one? @smithsp can you create a PR from your branch https://github.com/smithsp/matplotlib/tree/text-box-widget to mine https://github.com/fariza/matplotlib/tree/text-box-widget |
I'm not sure if |
Hi! Thanks for the friendly takeover -- sorry for dropping off the face of the earth there |
2bf21ab
to
2793d3a
Compare
@Nodraak for the time being I didn't take the |
…ed when text changes or text is submitted
…to aid readability
…and text from getting misaligned
2793d3a
to
bde1040
Compare
@tacaswell I don't think the failure is related. |
I merged #7006 which should fix the docs build error on Travis |
@jenshnielsen any idea on the appveyor fail? |
@fariza |
@smithsp maybe I'm lost in the logs, but I don't see a relation between this PR changes and the failure |
@fariza |
That is probably fixed by #7011 |
In that case, that's all from my side. Ready to merge |
Power cycling again |
Thanks everyone for getting this across the finish line! |
Thank you so much for your help! On Sat, Sep 3, 2016 at 4:09 PM, Thomas A Caswell notifications@github.com
|
Friendly take over of #5375