Tooltip: Improve the accessibility of the composer and the rich text editor #12459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
changed the title
AccessibleButton for composer & rich text editor
florianduros
force-pushed
the
florianduros/tooltip/composer
branch
from
cd23ca0
to
f49a9fd
Compare
florianduros
force-pushed
the
florianduros/tooltip/composer
branch
from
f49a9fd
to
d84f003
Compare
florianduros
added
the
T-Enhancement
# Conflicts: # src/accessibility/roving/RovingAccessibleTooltipButton.tsx
florianduros
changed the title
AccessibleButton for composer & rich text editor
florianduros
changed the title
t3chguy
reviewed
Apr 30, 2024
There was a problem hiding this comment.
The changes here feel like a visual regression, can design sign off on losing the keyboard key styling here?
There was a problem hiding this comment.
Actually my bad, there's no visual regression, only an a11y one. The kbd elements are lost and thus also are the semantics
Before:
There was a problem hiding this comment.
Good catch, will need to update the tooltip compound to be able this use case.
This was referenced May 3, 2024
florianduros
force-pushed
the
florianduros/tooltip/composer
branch
from
feb19b9
to
df840fe
Compare
florianduros
force-pushed
the
florianduros/tooltip/composer
branch
from
df840fe
to
64f1ab0
Compare
florianduros
changed the title
t3chguy
approved these changes
May 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 22, 2024
https://build.opensuse.org/request/show/1175893 by user dheidler + anag+factory - Version 1.11.67 ## ✨ Features * Tooltip: Improve the accessibility of the composer and the rich text editor (matrix-org/matrix-react-sdk#12459). Contributed by @florianduros. * Allow explicit configuration of OIDC dynamic registration metadata (matrix-org/matrix-react-sdk#12514). Contributed by @t3chguy. * Tooltip: improve accessibility for messages (matrix-org/matrix-react-sdk#12487). Contributed by @florianduros. * Collapse UserSettings tabs to just icons on narrow screens (matrix-org/matrix-react-sdk#12505). Contributed by @dbkr. * Add room topic to right panel room info (matrix-org/matrix-react-sdk#12503). Contributed by @t3chguy. * OIDC: pass `id_token
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 22, 2024
https://build.opensuse.org/request/show/1175898 by user dheidler + anag+factory - Version 1.11.67 ## ✨ Features * Tooltip: Improve the accessibility of the composer and the rich text editor (matrix-org/matrix-react-sdk#12459). Contributed by @florianduros. * Allow explicit configuration of OIDC dynamic registration metadata (matrix-org/matrix-react-sdk#12514). Contributed by @t3chguy. * Tooltip: improve accessibility for messages (matrix-org/matrix-react-sdk#12487). Contributed by @florianduros. * Collapse UserSettings tabs to just icons on narrow screens (matrix-org/matrix-react-sdk#12505). Contributed by @dbkr. * Add room topic to right panel room info (matrix-org/matrix-react-sdk#12503). Contributed by @t3chguy. * OIDC: pass `id_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Part of element-hq/element-web#26762
Following #12443,
AccessibleButtonincludes the new tooltip. We are migrating step by step the usage of the deprecatedAccessibleTooltipButtontoAccessibleButton.Depends of #12458 for
RovingAccessibleTooltipButtonmigration.Depends of element-hq/compound-web#165 to use
<kbd />for shortcut in tooltips of formatting buttons.Marking it at
T-Enhancementbecause it's in the objective to improve accessibility.Migrating both composer.