Tooltip: Use AccessibleButton in RovingAccessibleTooltipButton
#12458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Enhancement
florianduros
changed the title
AccessibleButton in RovingAccessibleTooltipButton
florianduros
changed the title
AccessibleButton in RovingAccessibleTooltipButtonAccessibleButton in RovingAccessibleTooltipButton
florianduros
force-pushed
the
florianduros/tooltip/roving-accessible-tooltip-button
branch
from
7a33efb
to
2a7f500
Compare
4 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
t3chguy
deleted the
florianduros/tooltip/roving-accessible-tooltip-button
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Part of element-hq/element-web#26762
Following #12443,
AccessibleButtonincludes the new tooltip. We are migrating step by step the usage of the deprecatedAccessibleTooltipButtontoAccessibleButton.Use
AccessibleButtoninRovingAccessibleTooltipButton.The
RovingAccessibleTooltipButtonusages will be replaced byRovingAccessibleButtonafter theAccessibleTooltipButton>AccessibleButtonmigration.Playwright screenshot change is due to that the new tooltip is smaller than the old one and is not visible on the new screenshot.