Support rails 5 #24
Open
Support rails 5 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should solve #23 |
dcosson
reviewed
Dec 31, 2016
| @@ -42,7 +42,7 @@ def call(env) | |||
| headers['Content-Type'] = Rack::Mime.mime_type(File.extname(path), 'text/plain') | |||
|
|
|||
| # Update cache-control to add directive telling Rack::Deflate to leave it alone. | |||
| cache_control = headers['Cache-Control'].try(:to_s).try(:downcase) | |||
| cache_control = headers['Cache-Control']&.to_s&.downcase | |||
There was a problem hiding this comment.
I'm not a maintainer or anything but would love to see this merged as I'm working on migrating a codebase to rails 5 that uses it.
I'm pretty sure this use of try still works fine in rails 5 though, so this change doesn't seem necessary and it would break support for ruby < 2.3
|
Please do fix the Rails 5 incompatibility. This problem has been noted elsewhere: On a project I'm on we've had to drop using heroku_rails_deflate because we're transitioning to Rails 5: |
|
Curious, is there anything hold up this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.