Support rails 5 v2 #25
Conversation
|
An alternative to using heroku_rails_deflate is to enable deflate in Rack. If you're using Rails, you're already using Rack, and Rack now has its own built-in deflate mechanism. You just need to enable it, e.g.:
I know that Rack at one time didn't include deflate. |
|
No kidding? That's really good to know, thanks! |
|
Sure! I just recently learned this myself, and it seems to work fine (when Amazon Web Services isn't having problems). This is a newer addition to Rack - when I originally added heroku_rails_deflate I'm pretty sure Rack didn't have this capability (or perhaps it wasn't as clearly documented). |
|
To be fair: The heroku_rails_deflate README specifically notes that it enables heroku_rails_deflate to perform its functionality. This heroku_rails_deflate gem does other (optimization) things, but since it didn't work with Rails 5, my approach was to go back-to-basics instead. You can decide what's best for your circumstance! |
|
I'd still really like to see this merged. Without heroku_rails_deflate, or something similar, we end up compressing already-compressed files. |
This is a copy of @st0012's PR #24. It just brings back the use of
.tryas recommended by @dcosson.