Use consistent handler defaults in docs and samples #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
commented
Mar 25, 2024
| @@ -47,6 +47,7 @@ public HttpMessageInvoker CreateClient(ForwarderHttpClientContext context) | |||
| AllowAutoRedirect = false, | |||
| AutomaticDecompression = DecompressionMethods.None, | |||
| UseCookies = false, | |||
| EnableMultipleHttp2Connections = true, | |||
There was a problem hiding this comment.
This change in the product code doesn't actually change anything as this setting will be overwritten by the config right after, but I wanted to keep all new SocketsHttpHandler looking the same in case someone copy-pastes it.
There was a problem hiding this comment.
well worth it. i made the mistake when copying and not realizing how it gets overwritten oater to true anyway. thanks.
MihaZupan
added
the
Type: Documentation
benjaminpetit
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2323